feat(avm): add isolated test cases for DIV/FDIV divide by zero#16394
Merged
feat(avm): add isolated test cases for DIV/FDIV divide by zero#16394
Conversation
✅ Deploy Preview for barretenberg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jeanmon
approved these changes
Aug 15, 2025
barretenberg/cpp/src/barretenberg/vm2/tracegen/alu_trace.test.cpp
Outdated
Show resolved
Hide resolved
MirandaWood
force-pushed
the
mw/avm-div-0-test
branch
2 times, most recently
from
3ddd876 to
84e021b
Compare
Adds a missing test case where we have a divide by zero error and the result `c` is *not* set in tracegen. Discovered by David, thank you!
AztecBot
force-pushed
the
mw/avm-div-0-test
branch
from
84e021b to
4bd1c9a
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a missing test case where we have a divide by zero error and the result
cis not set in tracegen. Discovered by David, thank you!