Skip to content

feat!: avm bugfix of erroneous tag error in tracegen on div by 0 #16388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MirandaWood merged 1 commit into from
Aug 15, 2025
Merged

feat!: avm bugfix of erroneous tag error in tracegen on div by 0 #16388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/vm2/constraining/relations/alu.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ class AluDivConstrainingTest : public AluConstrainingTest,
{
.alu_b_inv = div_0_error ? 0 : b.as_ff().invert(),
.alu_constant_64 = 64,
.alu_helper1 = remainder,
.alu_helper1 = div_0_error ? 0 : remainder.as_ff(),
.alu_ia = a,
.alu_ia_tag = tag,
.alu_ib = b,
Expand Down
3 changes: 2 additions & 1 deletion barretenberg/cpp/src/barretenberg/vm2/tracegen/alu_trace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ std::vector<std::pair<Column, FF>> get_operation_columns(const simulation::AluEv
}
case simulation::AluOperation::DIV: {
bool div_0_error = event.error == simulation::AluError::DIV_0_ERROR;
auto remainder = no_tag_err ? event.a - event.b * event.c : MemoryValue::from_tag(event.a.get_tag(), 0);
auto remainder =
no_tag_err && !div_0_error ? event.a - event.b * event.c : MemoryValue::from_tag(event.a.get_tag(), 0);
// Columns shared for all tags in a DIV:
std::vector<std::pair<Column, FF>> res = {
{ Column::alu_sel_op_div, 1 },
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/vm2/tracegen/alu_trace.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ TEST_P(AluDivTraceGenerationTest, TraceGenerationDiv)
ROW_FIELD_EQ(alu_ia, a),
ROW_FIELD_EQ(alu_ib, b),
ROW_FIELD_EQ(alu_ic, c),
ROW_FIELD_EQ(alu_helper1, a - b * c),
ROW_FIELD_EQ(alu_helper1, div_0_error ? 0 : (a - b * c).as_ff()),
ROW_FIELD_EQ(alu_ia_tag, static_cast<uint8_t>(tag)),
ROW_FIELD_EQ(alu_ib_tag, static_cast<uint8_t>(tag)),
ROW_FIELD_EQ(alu_ic_tag, static_cast<uint8_t>(tag)),
Expand Down
Loading