fix!: some missing context stuff in the AVM Cpp#16247
Merged
Conversation
Contributor
Author
dbanks12
force-pushed
the
db/fix-context
branch
from
1fb7a5f to
050501a
Compare
dbanks12
force-pushed
the
db/fix-context
branch
from
050501a to
a56d282
Compare
dbanks12
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
IlyasRidhuan
reviewed
Aug 7, 2025
| { .id = parent_context.get_context_id(), | ||
| .parent_id = parent_context.get_parent_id(), | ||
| .entered_context_id = context_provider.get_next_context_id(), | ||
| .entered_context_id = child_context->get_context_id(), // gets the context id of the child! |
Contributor
There was a problem hiding this comment.
ahh nice - yeah this makes sense now that we emit after we create. Must be a throwback when we use to recurse
IlyasRidhuan
approved these changes
Aug 7, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some bugs and missing stuff in cpp context