Conversation
nventuro
commented
Jul 31, 2025
|
|
||
| #[utility] | ||
| pub(crate) unconstrained fn private_balance_of(owner: AztecAddress) -> u128 { | ||
| unconstrained fn private_balance_of(owner: AztecAddress) -> u128 { |
Contributor
Author
There was a problem hiding this comment.
Pulled a Jan here: we no longer need for these functions to be pub as we no longer invoke them directly. Indeed we want to use noir-lang/noir#9363 to prevent that, but we don't yet have this feature because of the noir sync issue.
benesjan
force-pushed
the
nv/macro-cehcks
branch
from
9f4dc52 to
5862abb
Compare
Contributor
|
@nventuro The l2_to_l1 test was failing and this fixed it. In the function transformations we inject things like |
benesjan
approved these changes
Aug 1, 2025
|
|
||
| #[utility] | ||
| pub(crate) unconstrained fn private_balance_of(owner: AztecAddress) -> u128 { | ||
| unconstrained fn private_balance_of(owner: AztecAddress) -> u128 { |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2025
Documenting this function as it should have been documented in the first place. [This bug](#16149 (comment)) motivated me to do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are just some extra checks to try to prevent incorrect usage of these.