Conversation
Also adds handling for state-mutation attempts in C++ simulation. Followup work: 1. Constrain errors when attempting to mutate state or emit side effects in a static context.
dbanks12
requested review from
IlyasRidhuan,
LeilaWang,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
PR adds ECC error handling (is on curve checks) to the opcode handling variety. Internally used gadgets assume points are on curve. This is more optimal as we can make reasonable assumptions about the points when using them internally --------- Co-authored-by: MirandaWood <miranda@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See merge-train-readme.md.
BEGIN_COMMIT_OVERRIDE
feat!: constrain AVM EmitNullifier opcode (#15853)
feat(avm)!: ecc add error handling (#15781)
END_COMMIT_OVERRIDE