Skip to content

test: add public context txe + state var tests#15706

Merged
nventuro merged 1 commit intonextfrom
nv/initial-txe-pub-ctx-tests
Jul 15, 2025
Merged

test: add public context txe + state var tests#15706
nventuro merged 1 commit intonextfrom
nv/initial-txe-pub-ctx-tests

Conversation

@nventuro
Copy link
Contributor

This does a couple things, all closely related:

  • it enables the PublicImmutable tests, which were included in feat!: TXE #6985 but never run, with some rewriting using the new features
  • it adds PublicMutable tests
  • it adds env.public_context tests
  • it makes public_context smarter by being able to combine the committed and transient state for nullifiers in a pub context, allowing us to read transient nullifiers. This is avm behavior that we need to replicate in txe, but I don't think there'll be too much more of it.

@nventuro nventuro requested review from Thunkar and benesjan July 14, 2025 19:03
@nventuro nventuro enabled auto-merge July 14, 2025 19:38
});
}

#[test(should_fail)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error message?

}

#[test]
unconstrained fn read_uninitialized_public_same_tx() {
Copy link
Contributor

@Thunkar Thunkar Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read_initialized?

Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The age of reason is upon us

@nventuro nventuro added this pull request to the merge queue Jul 15, 2025
Merged via the queue into next with commit 0e1bfdb Jul 15, 2025
4 checks passed
@nventuro nventuro deleted the nv/initial-txe-pub-ctx-tests branch July 15, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants