feat(avm)!: Poseidon2 memory load and error handling#15693
Merged
Conversation
IlyasRidhuan
requested review from
Maddiaa0,
fcarreiro and
jeanmon
as code owners
IlyasRidhuan
force-pushed
the
ir/07-08-wip_refactor_taggedvalue
branch
6 times, most recently
from
512aac8 to
599998e
Compare
IlyasRidhuan
force-pushed
the
ir/07-04-feat_avm_poseidon2_mem_errs
branch
from
895fa78 to
a159881
Compare
IlyasRidhuan
changed the title
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/07-04-feat_avm_poseidon2_mem_errs
branch
from
a159881 to
9a654e3
Compare
This was referenced Jul 16, 2025
IlyasRidhuan
force-pushed
the
ir/07-04-feat_avm_poseidon2_mem_errs
branch
from
9a654e3 to
3edaf30
Compare
MirandaWood
reviewed
Jul 17, 2025
Contributor
MirandaWood
left a comment
MirandaWood
left a comment
There was a problem hiding this comment.
LGTM!! 🎉 Only a couple of nits. I'm not yet very confident with memory so you may want to wait for another review to see if I missed anything!
barretenberg/cpp/src/barretenberg/vm2/simulation/execution.test.cpp
Outdated
Show resolved
Hide resolved
IlyasRidhuan
force-pushed
the
ir/07-04-feat_avm_poseidon2_mem_errs
branch
from
3edaf30 to
5c3cdbc
Compare
fcarreiro
reviewed
Jul 18, 2025
barretenberg/cpp/src/barretenberg/vm2/simulation/merkle_check.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/simulation/poseidon2.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/tracegen/nullifier_tree_check_trace.test.cpp
Show resolved
Hide resolved
fcarreiro
reviewed
Jul 18, 2025
fcarreiro
reviewed
Jul 18, 2025
fcarreiro
reviewed
Jul 18, 2025
IlyasRidhuan
force-pushed
the
ir/07-04-feat_avm_poseidon2_mem_errs
branch
2 times, most recently
from
e2c3e82 to
f2c696a
Compare
IlyasRidhuan
commented
Jul 19, 2025
| @@ -0,0 +1,24 @@ | |||
| #pragma once | |||
Contributor
Author
There was a problem hiding this comment.
added fakes for poseidon2 and gt (the latter was helpful for poseidon2 tests)
IlyasRidhuan
force-pushed
the
ir/07-04-feat_avm_poseidon2_mem_errs
branch
from
f2c696a to
3a70554
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the memory aware portion of Poseidon2Permutation so it can be executed as part of the opcode. This includes error handling for OOB and invalid tag errors.
This has downstream impacts to alot of the tree op codes whose tests needed to be updated for the new poseidon2 definition.