fix: specify generic argument N of several structs#14967
Merged
Conversation
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
For noir-lang/noir#8686 When returning `dep::aztec::context::call_interfaces::PrivateStaticCallInterface` (and others) from some functions, the generic `N` argument wasn't specified. This will soon cause a compile error (like in Rust). I assumed the `N` argument is the size of the return type (I tried with zero first and it said it didn't find a `Deserialize<0>` impl for some types, so I figured the size in fields of the type was needed), but let me know if that's not how it should be done. Given that `size_in_fields` is now used in a couple of places, I decided to move it to its own file/module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For noir-lang/noir#8686
When returning
dep::aztec::context::call_interfaces::PrivateStaticCallInterface(and others) from some functions, the genericNargument wasn't specified. This will soon cause a compile error (like in Rust).I assumed the
Nargument is the size of the return type (I tried with zero first and it said it didn't find aDeserialize<0>impl for some types, so I figured the size in fields of the type was needed), but let me know if that's not how it should be done.Given that
size_in_fieldsis now used in a couple of places, I decided to move it to its own file/module.