Merged
Conversation
5 tasks
asterite
commented
May 28, 2025
asterite
commented
May 28, 2025
noir-projects/noir-protocol-circuits/crates/types/src/type_packing.nr
Outdated
Show resolved
Hide resolved
asterite
commented
May 28, 2025
noir-projects/noir-protocol-circuits/crates/types/src/abis/avm_circuit_public_inputs.nr
Outdated
Show resolved
Hide resolved
asterite
commented
May 28, 2025
noir-projects/noir-protocol-circuits/crates/types/src/abis/call_context.nr
Outdated
Show resolved
Hide resolved
asterite
commented
May 28, 2025
noir-projects/noir-protocol-circuits/crates/types/src/abis/public_call_request.nr
Outdated
Show resolved
Hide resolved
asterite
commented
May 28, 2025
noir-projects/noir-protocol-circuits/crates/types/src/abis/public_call_request.nr
Outdated
Show resolved
Hide resolved
LeilaWang
approved these changes
May 29, 2025
Contributor
LeilaWang
left a comment
LeilaWang
left a comment
There was a problem hiding this comment.
Thanks for fixing this 🙌
noir-projects/noir-protocol-circuits/crates/types/src/meta/mod.nr
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For noir-lang/noir#8703
In Noir, casting a number to bool is the same as casting that number to
u1first, then checking if thatu1is 0 or 1. That might be a bit unexpected, and actually in Rust you can't cast numbers to bool, so it's going to be disallowed soon.This PR changes
as boolto!= 0in most cases, though in some unpacking cases it seems the desired behavior was actually(value as u1) != 0, so there are a couple of those (without these a couple of tests fail).