Conversation
Contributor
Docs PreviewYou can check your preview here. |
6f1310b to
749e2d9
Compare
critesjosh
requested changes
May 27, 2025
docs/README.md
Outdated
|
|
||
| Adding docs: | ||
| - All docs changes, especially changes to `versioned_docs`, should only go to the `master` branch | ||
| - Exceptionally when documenting new protocol changes, these should go to the `next` branch, within `docs/docs` |
Contributor
There was a problem hiding this comment.
I think all docs changes should go into master. We don't have to publish what's in docs/docs (like we do now), which will contain future changes. This should prevent merge conflicts, otherwise I don't see how to prevent conflicts when merging master into next.
749e2d9 to
5741acd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.