Skip to content

fix: create GCP secret name if not provided #14509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spypsy merged 3 commits into from
May 27, 2025
Merged

fix: create GCP secret name if not provided #14509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15fc371
fix: generate secret name for sepolia accs mnemonic if not provided
spypsy May 23, 2025
f3e481f
fix final step
spypsy May 23, 2025
530c723
fix secrets access
spypsy May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/fund-sepolia-accounts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,10 @@ jobs:
run: |
echo "Saving mnemonic to GCP"
echo "::add-mask::${{ steps.fund-accounts.outputs.mnemonic }}"
gcloud secrets versions add latest --secret=${{ inputs.sepolia_accounts_mnemonic_secret_name }} --data-file="$MNEMONIC_FILE"
echo "Creating new secret ${{ inputs.sepolia_accounts_mnemonic_secret_name }}"
gcloud secrets create ${{ inputs.sepolia_accounts_mnemonic_secret_name }}
TMP_FILE=$(mktemp)
echo "${{ steps.fund-accounts.outputs.mnemonic }}" > "$TMP_FILE"
gcloud secrets versions add ${{ inputs.sepolia_accounts_mnemonic_secret_name }} --data-file="$TMP_FILE"
rm "$TMP_FILE"
echo "Saved mnemonic to GCP secret ${{ inputs.sepolia_accounts_mnemonic_secret_name }}"
17 changes: 13 additions & 4 deletions .github/workflows/network-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,17 @@ on:
type: string
default: "false"
sepolia_accounts_mnemonic_secret_name:
description: The name of the secret which holds the sepolia accounts mnemonic (required for sepolia deployment)
description: The name of the secret which holds the sepolia accounts mnemonic (if not provided, will use '{namespace}-accounts-mnemonic').
required: false
type: string
default: sepolia-accounts-mnemonic

jobs:
fund_sepolia_accounts:
if: ${{ inputs.sepolia_deployment == 'true' }}
uses: ./.github/workflows/fund-sepolia-accounts.yml
with:
values_file: ${{ inputs.values_file }}
sepolia_accounts_mnemonic_secret_name: ${{ inputs.sepolia_accounts_mnemonic_secret_name }}
sepolia_accounts_mnemonic_secret_name: ${{ inputs.sepolia_accounts_mnemonic_secret_name || format('{0}-accounts-mnemonic', inputs.namespace) }}
ref: ${{ inputs.ref || github.ref || 'master' }}
secrets:
GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }}
Expand Down Expand Up @@ -212,6 +211,11 @@ jobs:
continue-on-error: true
run: |
if ${{ inputs.sepolia_deployment == 'true' }}; then
if [ -z "${{ inputs.sepolia_accounts_mnemonic_secret_name }}" ]; then
SECRET_NAME="${{ env.NAMESPACE }}-accounts-mnemonic"
else
SECRET_NAME="${{ inputs.sepolia_accounts_mnemonic_secret_name }}"
fi
L1_DEPLOYMENT_MNEMONIC=$(gcloud secrets versions access latest --secret=${{ inputs.sepolia_accounts_mnemonic_secret_name }})
terraform destroy -auto-approve \
-var="RELEASE_NAME=${{ env.NAMESPACE }}" \
Expand Down Expand Up @@ -243,7 +247,12 @@ jobs:
working-directory: ./spartan/terraform/deploy-release
run: |
if ${{ inputs.sepolia_deployment == 'true' }}; then
L1_DEPLOYMENT_MNEMONIC=$(gcloud secrets versions access latest --secret=${{ inputs.sepolia_accounts_mnemonic_secret_name }})
if [ -z "${{ inputs.sepolia_accounts_mnemonic_secret_name }}" ]; then
SECRET_NAME="${{ env.NAMESPACE }}-accounts-mnemonic"
else
SECRET_NAME="${{ inputs.sepolia_accounts_mnemonic_secret_name }}"
fi
L1_DEPLOYMENT_MNEMONIC=$(gcloud secrets versions access latest --secret=$SECRET_NAME)
terraform plan \
-var="RELEASE_NAME=${{ env.NAMESPACE }}" \
-var="VALUES_FILE=${{ env.VALUES_FILE }}" \
Expand Down