chore: Add type annotation so the inferred type isn't Field#14507
Merged
chore: Add type annotation so the inferred type isn't Field#14507
Conversation
5 tasks
vezenovm
approved these changes
May 23, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 23, 2025
In preparation for noir-lang/noir#8635 where the format of `Field` printed at `comptime` will change from numeric to hexadecimal, to match the behaviour of the runtime. A slight inconvenience is that `let x = 0;` seems to be inferred to be `Field` by the compiler, which would show up as `0x00`, which in this case disrupted the macro, as what has been rendered as `arg0` became `arg0x00`.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for noir-lang/noir#8635 where the format of
Fieldprinted atcomptimewill change from numeric to hexadecimal, to match the behaviour of the runtime. A slight inconvenience is thatlet x = 0;seems to be inferred to beFieldby the compiler, which would show up as0x00, which in this case disrupted the macro, as what has been rendered asarg0becamearg0x00.