Merged
Conversation
TomAFrench
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have code like this:
then Noir, unlike Rust, doesn't complain that the left-hand side tuple doesn't have exactly the number of elements that are on the right side.
That's about to change (it's a bug) when this PR merges: noir-lang/noir#8424
Before that, we can fix the existing errors here.
I chose to ignore the extra tuple element because it's currently ignored, but I don't know if the "owner" should be used for something in tests (alternatively maybe "owner" should not be returned if it's not going to be used).