chore(ci): Update acir tests to reflect compilation based off of package name#1405
Merged
chore(ci): Update acir tests to reflect compilation based off of package name#1405
Conversation
Contributor
Author
|
@ludamad acir tests passing here |
Contributor
Author
|
Actually don't bother reviewing yet as I will have to change the branch back to master once the Noir PR is merged and it will dismiss your review |
TomAFrench
reviewed
Aug 3, 2023
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
ludamad
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACIR tests are failing and needed a refresh on the Noir side. However, there has been a change where compilation is specified off of the package name in the
Nargo.tomlrather than a specified file name such asmain.jsonChecklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.