fix(starknet-bb): Clears extraneous MSB from r_inv_wasm_5/r_inv_wasm_7#13704
Merged
ludamad merged 3 commits intoAztecProtocol:masterfrom May 7, 2025
Merged
fix(starknet-bb): Clears extraneous MSB from r_inv_wasm_5/r_inv_wasm_7#13704ludamad merged 3 commits intoAztecProtocol:masterfrom
ludamad merged 3 commits intoAztecProtocol:masterfrom
Conversation
ludamad
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix a bb.js/WASM bug for the UltraStarknetFlavor. Unfortunately, it was introduced by the original implementation (#11489).
In short, the STARK252 field constants
r_inv_wasm_5andr_inv_wasm_7were declared with 30-bits when 29-bits are expected.Hopefully this simple change should fix bb.js's buggy behavior.
@ludamad Please take a look, thanks in advance