Skip to content

chore(release): give aztec release image sensible default entrypoint #13517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maddiaa0 merged 2 commits into from
Apr 22, 2025
Merged

chore(release): give aztec release image sensible default entrypoint #13517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4938dac
chore: make entry point default
Maddiaa0 Apr 14, 2025
81b0145
chore: override entrypoint to make aztec start work as usual
Maddiaa0 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aztec-up/bin/.aztec-run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ function run {
${arg_env_vars:-} \
${arg_host_binds:-} \
${arg_user:-} \
--entrypoint "" \
aztecprotocol/aztec:$VERSION "${args[@]}"
}

Expand Down
1 change: 1 addition & 0 deletions release-image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ ENV ACVM_WORKING_DIRECTORY=/usr/src/acvm
ENV ACVM_BINARY_PATH=/usr/src/noir/noir-repo/target/release/acvm
RUN mkdir -p $BB_WORKING_DIRECTORY $ACVM_WORKING_DIRECTORY && chmod 777 $BB_WORKING_DIRECTORY $ACVM_WORKING_DIRECTORY
WORKDIR "/usr/src/yarn-project"
ENTRYPOINT ["/bin/bash", "-c", "node --no-warnings /usr/src/yarn-project/aztec/dest/bin/index.js"]
5 changes: 2 additions & 3 deletions release-image/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ We then manually install our required version of node, and a handful of require

# Entrypoint

The entrypoint is just the default bash shell.
This means when running the container, you should pass as arguments the desired entrypoint and arguments.
This could be nargo, aztec-wallet, aztec cli, anvil, etc.
The entrypoint will the aztec cli, you should pass as arguments the desired entrypoint and arguments.
When wanting to run nargo, aztec-wallet, aztec cli, anvil, etc, update the entrypoint to just be bash before executing.