Skip to content

chore: don't dump on fail. click the link instead. #13292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlielye merged 2 commits into from
Apr 4, 2025
Merged

chore: don't dump on fail. click the link instead. #13292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c613e
chore: don't dump on fail. click the link instead.
charlielye Apr 3, 2025
e678b1c
dump only if in terminal
charlielye Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ci3/denoise
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@ publish_log

# Handle non-zero exit status
if [ "$status" -ne 0 ]; then
echo -e "\nCommand exited with status $status. Dumping output:"
cat $outfile
if [ -t 1 ]; then
echo -e "\nCommand exited with status $status. Dumping output:"
cat $outfile
fi
echo -e ". ${red}failed${reset} ($time) ${log_info:-}"
else
echo -e ". ${green}done${reset} ($time)"
Expand Down
6 changes: 4 additions & 2 deletions ci3/run_test_cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,10 @@ function fail {
track_test $test_hash "$line"
track_test "failed_tests" "$line"
echo -e "$line"
cat $tmp_file
echo -e "$line"
if [ -t 1 ]; then
cat $tmp_file
echo -e "$line"
fi
exit $code
}

Expand Down