Skip to content

fix: test tracking failures in merge queue #13235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlielye merged 2 commits into from
Apr 2, 2025
Merged

fix: test tracking failures in merge queue #13235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ef3d9c
fix: test tracking failures in merge queue
charlielye Apr 2, 2025
b88c7dc
only grind in merge queue
charlielye Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ jobs:

ci-grind:
runs-on: ubuntu-latest
if: github.event_name == 'merge_group' || (github.event_name == 'push' && github.ref_name == 'master')
if: github.event_name == 'merge_group'
strategy:
matrix:
number: [1, 2, 3, 4, 5]
Expand Down
11 changes: 6 additions & 5 deletions ci3/run_test_cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,13 @@ fi
function track_test {
local test_hash=$1
local line=$2
if [ "$REF_NAME" != "master" ]; then
return

# We track tests in CI, and only on master or master merge queue.
if [[ "$CI" -eq 1 && ( "$REF_NAME" == "master" || "$REF_NAME" =~ ^gh-readonly-queue/master/ ) ]]; then
redis_cli LPUSH $test_hash "$(date "+%m-%d %H:%M:%S"): $(echo -e "$line")" &>/dev/null
# Keeps only the last 1000 lines.
redis_cli RTRIM $test_hash -1000 -1 &>/dev/null
fi
redis_cli LPUSH $test_hash "$(date "+%m-%d %H:%M:%S"): $(echo -e "$line")" &>/dev/null
# Keeps only the last 1000 lines.
redis_cli RTRIM $test_hash -1000 -1 &>/dev/null
}

# Show PASSED and early out on success.
Expand Down