Skip to content

chore: more benchmarking #13211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thunkar merged 2 commits into from
Apr 3, 2025
Merged

chore: more benchmarking #13211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bcdff5
more benchmarking
Thunkar Apr 1, 2025
668e840
fmt
Thunkar Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion yarn-project/end-to-end/src/bench/client_flows/client_flows_benchmark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
type AccountWallet,
AztecAddress,
type AztecNode,
FeeJuicePaymentMethod,
FeeJuicePaymentMethodWithClaim,
type FeePaymentMethod,
type Logger,
Expand Down Expand Up @@ -52,7 +53,7 @@ const { E2E_DATA_PATH: dataPath, BENCHMARK_CONFIG } = process.env;

export type AccountType = 'ecdsar1' | 'schnorr';
export type FeePaymentMethodGetter = (wallet: Wallet) => Promise<FeePaymentMethod>;
export type BenchmarkingFeePaymentMethod = 'bridged_fee_juice' | 'private_fpc' | 'sponsored_fpc';
export type BenchmarkingFeePaymentMethod = 'bridged_fee_juice' | 'private_fpc' | 'sponsored_fpc' | 'fee_juice';

export class ClientFlowsBenchmark {
private snapshotManager: ISnapshotManager;
Expand Down Expand Up @@ -111,6 +112,11 @@ export class ClientFlowsBenchmark {
forWallet: this.getSponsoredFPCPaymentMethodForWallet.bind(this),
circuits: 2, // Sponsored FPC sponsor_unconditionally + kernel inner
},
// eslint-disable-next-line camelcase
fee_juice: {
forWallet: this.getFeeJuicePaymentMethodForWallet.bind(this),
circuits: 0,
},
};

public config: ClientFlowsConfig;
Expand Down Expand Up @@ -394,4 +400,8 @@ export class ClientFlowsBenchmark {
public getSponsoredFPCPaymentMethodForWallet(_wallet: Wallet) {
return Promise.resolve(new SponsoredFeePaymentMethod(this.sponsoredFPC.address));
}

public getFeeJuicePaymentMethodForWallet(wallet: Wallet) {
return Promise.resolve(new FeeJuicePaymentMethod(wallet.getAddress()));
}
}
4 changes: 2 additions & 2 deletions yarn-project/end-to-end/src/bench/client_flows/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export const KEY_FLOWS_CONFIG: ClientFlowsConfig = {
feePaymentMethods: ['sponsored_fpc'],
},
transfers: {
accounts: ['ecdsar1'],
feePaymentMethods: ['sponsored_fpc'],
accounts: ['ecdsar1', 'schnorr'],
feePaymentMethods: ['sponsored_fpc', 'fee_juice'],
recursions: [1],
},
};
Expand Down