Skip to content

chore: log out the slash factory when a new rollup is deployed #13131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
just-mitch merged 1 commit into from
Mar 29, 2025
Merged

chore: log out the slash factory when a new rollup is deployed #13131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion yarn-project/cli/src/cmds/l1/deploy_new_rollup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export async function deployNewRollup(
const initialFundedAccounts = testAccounts ? await getInitialTestAccounts() : [];
const { genesisBlockHash, genesisArchiveRoot } = await getGenesisValues(initialFundedAccounts.map(a => a.address));

const { payloadAddress, rollup } = await deployNewRollupContracts(
const { payloadAddress, rollup, slashFactoryAddress } = await deployNewRollupContracts(
registryAddress,
rpcUrls,
chainId,
Expand All @@ -46,6 +46,7 @@ export async function deployNewRollup(
{
payloadAddress: payloadAddress.toString(),
rollupAddress: rollup.address,
slashFactoryAddress: slashFactoryAddress.toString(),
},
null,
2,
Expand All @@ -54,5 +55,6 @@ export async function deployNewRollup(
} else {
log(`Payload Address: ${payloadAddress.toString()}`);
log(`Rollup Address: ${rollup.address}`);
log(`Slash Factory Address: ${slashFactoryAddress.toString()}`);
}
}
6 changes: 3 additions & 3 deletions yarn-project/cli/src/utils/aztec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export async function deployNewRollupContracts(
genesisBlockHash: Fr,
config: L1ContractsConfig,
logger: Logger,
): Promise<{ payloadAddress: EthAddress; rollup: RollupContract }> {
): Promise<{ payloadAddress: EthAddress; rollup: RollupContract; slashFactoryAddress: EthAddress }> {
const { createEthereumChain, deployRollupForUpgrade, createL1Clients } = await import('@aztec/ethereum');
const { mnemonicToAccount, privateKeyToAccount } = await import('viem/accounts');
const { getVKTreeRoot } = await import('@aztec/noir-protocol-circuits-types/vk-tree');
Expand All @@ -107,7 +107,7 @@ export async function deployNewRollupContracts(
const chain = createEthereumChain(rpcUrls, chainId);
const clients = createL1Clients(rpcUrls, account, chain.chainInfo, mnemonicIndex);

const { payloadAddress, rollup } = await deployRollupForUpgrade(
const { payloadAddress, rollup, slashFactoryAddress } = await deployRollupForUpgrade(
clients,
{
salt,
Expand All @@ -124,7 +124,7 @@ export async function deployNewRollupContracts(
config,
);

return { payloadAddress, rollup };
return { payloadAddress, rollup, slashFactoryAddress };
}

/**
Expand Down