Skip to content

fix: boolean config helper for cli args works now #13110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
just-mitch merged 1 commit into from
Mar 28, 2025
Merged

fix: boolean config helper for cli args works now #13110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions yarn-project/aztec/src/cli/aztec_start_options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,13 @@ export const aztecStartOptions: { [key: string]: AztecStartOption[] } = {
envVar: undefined,
},
{
flag: '--sandbox.testAccounts',
flag: '--sandbox.testAccounts [value]',
description: 'Deploy test accounts on sandbox start',
envVar: 'TEST_ACCOUNTS',
...booleanConfigHelper(true),
...booleanConfigHelper(),
},
{
flag: '--sandbox.noPXE',
flag: '--sandbox.noPXE [value]',
description: 'Do not expose PXE service on sandbox start',
envVar: 'NO_PXE',
...booleanConfigHelper(),
Expand Down Expand Up @@ -268,7 +268,7 @@ export const aztecStartOptions: { [key: string]: AztecStartOption[] } = {
parseVal: val => parseInt(val, 10),
},
{
flag: '--node.testAccounts',
flag: '--node.testAccounts [value]',
description: 'Populate genesis state with initial fee juice for test accounts',
envVar: 'TEST_ACCOUNTS',
...booleanConfigHelper(),
Expand All @@ -289,7 +289,7 @@ export const aztecStartOptions: { [key: string]: AztecStartOption[] } = {
],
'P2P SUBSYSTEM': [
{
flag: '--p2p-enabled',
flag: '--p2p-enabled [value]',
description: 'Enable P2P subsystem',
envVar: 'P2P_ENABLED',
...booleanConfigHelper(),
Expand Down
3 changes: 2 additions & 1 deletion yarn-project/aztec/src/sandbox/sandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,11 @@ export async function createSandbox(config: Partial<SandboxConfig> = {}, userLog
}

const initialAccounts = await (async () => {
if (config.testAccounts) {
if (config.testAccounts === true || config.testAccounts === undefined) {
if (aztecNodeConfig.p2pEnabled) {
userLog(`Not setting up test accounts as we are connecting to a network`);
} else {
userLog(`Setting up test accounts`);
return await getInitialTestAccounts();
}
}
Expand Down