Skip to content

feat: derived pending notes capsules slot #13102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benesjan merged 1 commit into from
Mar 28, 2025
Merged

feat: derived pending notes capsules slot #13102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions noir-projects/aztec-nr/aztec/src/discovery/partial_notes.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ use dep::protocol_types::{
address::AztecAddress,
constants::PUBLIC_LOG_DATA_SIZE_IN_FIELDS,
debug_log::debug_log_format,
hash::sha256_to_field,
traits::{Deserialize, Serialize, ToField},
};

Expand All @@ -24,8 +25,9 @@ pub global MAX_PARTIAL_NOTE_PRIVATE_PACKED_LEN: u32 =
MAX_LOG_CONTENT_LEN - PARTIAL_NOTE_PRIVATE_LOG_CONTENT_NON_NOTE_FIELDS_LEN;

/// The slot in the PXE capsules where we store a `CapsuleArray` of `DeliveredPendingPartialNote`.
// TODO(#11630): come up with some sort of slot allocation scheme.
pub global DELIVERED_PENDING_PARTIAL_NOTE_ARRAY_LENGTH_CAPSULES_SLOT: Field = 77;
pub global DELIVERED_PENDING_PARTIAL_NOTE_ARRAY_LENGTH_CAPSULES_SLOT: Field = sha256_to_field(
"DELIVERED_PENDING_PARTIAL_NOTE_ARRAY_LENGTH_CAPSULES_SLOT".as_bytes(),
Comment on lines +28 to +29
Copy link
Contributor

@nventuro nventuro Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y u no review request

Two comments:
a) let's add a domain separator to avoid having to think about users using capsules, e.g. hash(["aztec-nr", name])
b) can this be made comptime? i guess this is perhaps not a huge issue since capsules are unconstrained, so we should never need to compute these values in circuits

Copy link
Contributor Author

@benesjan benesjan Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b) globals are always comptime

Copy link
Contributor Author

@benesjan benesjan Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vezenovm can you please confirm that I am not lying here?

Copy link
Contributor

@vezenovm vezenovm Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, globals are all computed at comptime

);

/// Public logs contain an extra field at the beginning with the address of the contract that emitted them, and partial
/// notes emit their completion tag in the log, resulting in the first two fields in the public log not being part of
Expand Down