Skip to content

chore: remove dummy ops in decider pk #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maramihali merged 2 commits into from
Mar 26, 2025
Merged

chore: remove dummy ops in decider pk #13049

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a51f9f6
remove dummy ops in DeciderPK construction
Mar 26, 2025
d60dbe5
Merge remote-tracking branch 'origin/master' into mm/try
Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,6 @@ template <IsUltraFlavor Flavor> class DeciderProvingKey_ {
}
}

// TODO(https://github.com/AztecProtocol/barretenberg/issues/905): This is adding ops to the op queue but NOT to
// the circuit, meaning the ECCVM/Translator will use different ops than the main circuit. This will lead to
// failure once https://github.com/AztecProtocol/barretenberg/issues/746 is resolved.
if constexpr (IsMegaFlavor<Flavor>) {
circuit.op_queue->append_nonzero_ops();
}
vinfo("allocating polynomials object in proving key...");
{
PROFILE_THIS_NAME("allocating proving key");
Expand Down