Skip to content

chore: Fix missing fee asset config #13004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilWindle merged 2 commits into from
Mar 25, 2025
Merged

chore: Fix missing fee asset config #13004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da0d4ef
Missing config
PhilWindle Mar 25, 2025
07b4d81
New chain default config
PhilWindle Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spartan/aztec-network/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,8 @@ Combined wait-for-services and configure-env container for full nodes
value: "{{ .Values.aztec.contracts.registryAddress }}"
- name: SLASH_FACTORY_CONTRACT_ADDRESS
value: "{{ .Values.aztec.contracts.slashFactoryAddress }}"
- name: FEE_ASSET_HANDLER_CONTRACT_ADDRESS
Copy link
Collaborator

@just-mitch just-mitch Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yikes that is my bad. Very sorry.

value: "{{ .Values.aztec.contracts.feeAssetHandlerContractAddress }}"
{{- end -}}

{{/*
Expand Down
1 change: 1 addition & 0 deletions spartan/aztec-network/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ aztec:
contracts:
registryAddress: ""
slashFactoryAddress: ""
feeAssetHandlerContractAddress: ""

slotDuration: 36 # in seconds, aka L2 slot duration. Must be a multiple of {{ ethereum.blockTime }}
epochDuration: 32 # how many L2 slots in an epoch
Expand Down
1 change: 1 addition & 0 deletions spartan/aztec-network/values/alpha-testnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ aztec:
contracts:
registryAddress: "0xad85d55a4bbef35e95396191c22903aa717edf1c"
slashFactoryAddress: "0xf667f50fd68b30c38b12d29fee537fa5ea158eb8"
feeAssetHandlerContractAddress: "0xf0664fec6ac15313e18d5ad8225e46b7c6463338"

network:
public: true
Expand Down
4 changes: 4 additions & 0 deletions yarn-project/aztec/src/cli/chain_l2_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export type L2ChainConfig = {
p2pBootstrapNodes: string[];
registryAddress: string;
slashFactoryAddress: string;
feeAssetHandlerAddress: string;
seqMinTxsPerBlock: number;
seqMaxTxsPerBlock: number;
realProofs: boolean;
Expand All @@ -33,6 +34,7 @@ export const testnetIgnitionL2ChainConfig: L2ChainConfig = {
p2pBootstrapNodes: [],
registryAddress: '0x12b3ebc176a1646b911391eab3760764f2e05fe3',
slashFactoryAddress: '',
feeAssetHandlerAddress: '',
seqMinTxsPerBlock: 0,
seqMaxTxsPerBlock: 0,
realProofs: true,
Expand All @@ -50,6 +52,7 @@ export const alphaTestnetL2ChainConfig: L2ChainConfig = {
p2pBootstrapNodes: [],
registryAddress: '0xad85d55a4bbef35e95396191c22903aa717edf1c',
slashFactoryAddress: '0xf667f50fd68b30c38b12d29fee537fa5ea158eb8',
feeAssetHandlerAddress: '0xf0664fec6ac15313e18d5ad8225e46b7c6463338',
seqMinTxsPerBlock: 0,
seqMaxTxsPerBlock: 4,
realProofs: true,
Expand Down Expand Up @@ -105,6 +108,7 @@ export async function enrichEnvironmentWithChainConfig(networkName: NetworkNames
enrichVar('L1_CHAIN_ID', config.l1ChainId.toString());
enrichVar('REGISTRY_CONTRACT_ADDRESS', config.registryAddress);
enrichVar('SLASH_FACTORY_CONTRACT_ADDRESS', config.slashFactoryAddress);
enrichVar('FEE_ASSET_HANDLER_CONTRACT_ADDRESS', config.feeAssetHandlerAddress);
enrichVar('SEQ_MIN_TX_PER_BLOCK', config.seqMinTxsPerBlock.toString());
enrichVar('SEQ_MAX_TX_PER_BLOCK', config.seqMaxTxsPerBlock.toString());
enrichVar('DATA_DIRECTORY', path.join(process.env.HOME || '~', '.aztec', networkName, 'data'));
Expand Down