fix: mac publish should use clang 18 like x-compiler, and use it

.github/workflows/publish-bb-mac.yml

@@ -37,7 +37,9 @@ jobs:
           ref: ${{ inputs.tag || github.sha }}
 
       - name: Create Mac Build Environment
-        run: brew install cmake ninja llvm@16
+        run: |
+          brew install cmake ninja llvm@18
+          echo "BREW_PREFIX=$(brew --prefix)" >> $GITHUB_ENV
 
       - name: Replace version string in main.cpp
         working-directory: barretenberg/cpp
@@ -47,11 +49,8 @@ jobs:
       - name: Compile Barretenberg
         working-directory: barretenberg/cpp
         run: |
-          export PATH="/usr/local/opt/llvm@16/bin:$PATH"
-          export LDFLAGS="-L/usr/local/opt/llvm@16/lib"
-          export CPPFLAGS="-I/usr/local/opt/llvm@16/include"
-          cmake -DCMAKE_BUILD_TYPE=RelWithAssert --preset default
-          cmake --build --preset default --target bb
+          cmake --preset homebrew
+          cmake --build --preset homebrew --target bb
 
       - name: Package barretenberg artifact (amd64-darwin)
         working-directory: barretenberg/cpp/build/bin
@@ -77,7 +76,9 @@ jobs:
           ref: ${{ inputs.tag || github.sha }}
 
       - name: Create Mac Build Environment
-        run: brew install cmake ninja
+        run: |
+          brew install cmake ninja llvm@18
+          echo "BREW_PREFIX=$(brew --prefix)" >> $GITHUB_ENV
 
       - name: Replace version string in main.cpp
         working-directory: barretenberg/cpp
@@ -87,8 +88,8 @@ jobs:
       - name: Compile Barretenberg
         working-directory: barretenberg/cpp
         run: |
-          cmake --preset default -DCMAKE_BUILD_TYPE=RelWithAssert
-          cmake --build --preset default --target bb
+          cmake --preset homebrew
+          cmake --build --preset homebrew --target bb
 
       - name: Package barretenberg artifact (arm64-darwin)
         working-directory: barretenberg/cpp/build/bin

barretenberg/cpp/CMakePresets.json

@@ -44,8 +44,8 @@
       "description": "Build with Clang installed via Homebrew",
       "inherits": "default",
       "environment": {
-        "CC": "$env{BREW_PREFIX}/opt/llvm/bin/clang",
-        "CXX": "$env{BREW_PREFIX}/opt/llvm/bin/clang++"
+        "CC": "$env{BREW_PREFIX}/opt/llvm@18/bin/clang",
+        "CXX": "$env{BREW_PREFIX}/opt/llvm@18/bin/clang++"
       }
     },
     {
@@ -79,6 +79,16 @@
         "OSXCROSS_HOST": "x86_64-apple-darwin23"
       }
     },
+    {
+      "name": "clang18",
+      "displayName": "Build with Clang-18",
+      "description": "Build with globally installed Clang-18",
+      "inherits": "default",
+      "environment": {
+        "CC": "clang-18",
+        "CXX": "clang++-18"
+      }
+    },
     {
       "name": "clang16",
       "displayName": "Build with Clang-16",
@@ -197,6 +207,16 @@
         "CHECK_CIRCUIT_STACKTRACES": "ON"
       }
     },
+    {
+      "name": "clang18-assert",
+      "binaryDir": "build",
+      "displayName": "Build with Clang-18 using RelWithAssert",
+      "description": "Build with globally installed Clang-18 in release with ASSERTs mode",
+      "inherits": "clang18",
+      "environment": {
+        "CMAKE_BUILD_TYPE": "RelWithAssert"
+      }
+    },
     {
       "name": "clang16-assert",
       "binaryDir": "build",
@@ -503,6 +523,11 @@
       "inherits": "default",
       "configurePreset": "homebrew"
     },
+    {
+      "name": "clang18",
+      "inherits": "default",
+      "configurePreset": "clang18"
+    },
     {
       "name": "clang16",
       "inherits": "default",
@@ -573,6 +598,11 @@
       "inherits": "clang16-dbg-fast",
       "configurePreset": "clang16-dbg-fast-circuit-check-traces"
     },
+    {
+      "name": "clang18-assert",
+      "inherits": "default",
+      "configurePreset": "clang18-assert"
+    },
     {
       "name": "clang16-assert",
       "inherits": "default",

barretenberg/cpp/src/CMakeLists.txt

@@ -28,6 +28,8 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
         add_compile_options(-Wno-vla-cxx-extension)
         # This gets in the way of a partial object initialization (i.e. MyClass my_class{ .my_member = init_value })
         add_compile_options(-Wno-missing-field-initializers)
+        # CLI11.hpp
+        add_compile_options(-Wno-deprecated-declarations)
     endif()
 endif()
 

ci3/npm_install_deps

@@ -23,7 +23,7 @@ if [ "$CI" -eq 1 ] && [ -f $HOME/ci-started ]; then
   nm_hash=$(cache_content_hash "^$yarn_lock_path" "^$package_json_path")
   if ! cache_download node-modules-$nm_hash.zst; then
     denoise "retry 'yarn install --immutable'"
-    cache_upload node-modules-$nm_hash.zst node_modules
+    cache_upload node-modules-$nm_hash.zst $(find . -type d -iname node_modules -not -path "*/node_modules/*")
   fi
 else
   denoise "yarn install"