refactor: nuking note filtration by TxHash#12821
Closed
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
changed the title
TxHash
Base automatically changed from
03-17-refacotr_minor_commitmentsdb_cleanup
to
master
March 18, 2025 02:48
benesjan
force-pushed
the
03-17-refactor_nuking_txhash_from_notefilter
branch
from
1c0271d to
2262cc7
Compare
Contributor
|
As part of #12803, a lot of this is removed. Can you please wait until that one is in before merging? |
Contributor
Author
|
Closing as it was decided by higher powers that we want to keep the TxHash there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nuking TxHash from NoteDao and NoteFilter in preparation for #12550