fix(docs): link noir-docs site#12751
Closed
anaPerezGhiglia wants to merge 1 commit intoAztecProtocol:masterfrom
Closed
fix(docs): link noir-docs site#12751anaPerezGhiglia wants to merge 1 commit intoAztecProtocol:masterfrom
anaPerezGhiglia wants to merge 1 commit intoAztecProtocol:masterfrom
Conversation
Member
|
Hey Ana, thanks for this PR but I've addressed this over in noir-lang/noir#7720 to avoid the trailing slash from being an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
Noir docsreference nav bar menu item was broken. When clicking on it the user was navigated to a Noir page that shows aPage not foundscreennoir_docs_broken_link.mov
Changes
The link was pointing to
https://noir-lang.org/docs.This PR changes that so it points to
https://noir-lang.org/docs/, that's were Noir is actually serving the documentation