-
Notifications
You must be signed in to change notification settings - Fork 598
chore: Update references to GH issues to reflect recent changes #12722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,8 @@ | |
| // with the non-constexpr setting. Right now everything is more or less duplicated across BarycentricDataCompileTime and | ||
| // BarycentricDataRunTime. There should be a way to share more of the logic. | ||
|
|
||
| /* IMPROVEMENT(Cody): This could or should be improved in various ways. In no particular order: | ||
| /* TODO(https://github.com/AztecProtocol/barretenberg/issues/10): This could or should be improved in various ways. In | ||
| no particular order: | ||
| 1) Edge cases are not considered. One non-use case situation (I forget which) leads to a segfault. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prob trying to evaluate a univariate at one of the domain points? this leads to an edge case in sumcheck recursive verifier |
||
|
|
||
| 2) Precomputing for all possible size pairs is probably feasible and might be a better solution than instantiating | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -376,6 +376,7 @@ template <typename Builder> field_t<Builder> field_t<Builder>::pow(const field_t | |
| } | ||
|
|
||
| bool exponent_constant = exponent.is_constant(); | ||
| // TODO(https://github.com/AztecProtocol/barretenberg/issues/446): optimize by allowing smaller expoonent | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo in exponent |
||
| std::vector<bool_t<Builder>> exponent_bits(32); | ||
| for (size_t i = 0; i < exponent_bits.size(); ++i) { | ||
| uint256_t value_bit = exponent_value & 1; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very expressive naming :D