Skip to content

feat(bb): extend_edges optimization for zero values past end_index #12703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeanmon merged 3 commits into from
Mar 14, 2025
Merged

feat(bb): extend_edges optimization for zero values past end_index #12703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b0f33
extend_edges optimization for zero values past end_index
Mar 12, 2025
f0bbae8
Addressing some review comment
Mar 13, 2025
4af8259
Addressing review feedback
Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion barretenberg/cpp/src/barretenberg/sumcheck/sumcheck_round.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,12 @@ template <typename Flavor> class SumcheckProverRound {
if constexpr (Flavor::USE_SHORT_MONOMIALS) {
extended_edge = edge;
} else {
extended_edge = edge.template extend_to<MAX_PARTIAL_RELATION_LENGTH>();
if (multivariate.end_index() < edge_idx) {
static const auto zero_univariate = bb::Univariate<FF, MAX_PARTIAL_RELATION_LENGTH>::zero();
extended_edge = zero_univariate;
} else {
extended_edge = edge.template extend_to<MAX_PARTIAL_RELATION_LENGTH>();
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion bb-pilcom/bb-pil-backend/templates/flavor.cpp.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ AvmFlavor::PartiallyEvaluatedMultivariates::PartiallyEvaluatedMultivariates(cons
{
for (auto [poly, full_poly] : zip_view(get_all(), full_polynomials.get_all())) {
// After the initial sumcheck round, the new size is CEIL(size/2).
size_t desired_size = std::min(full_poly.end_index() / 2 + full_poly.end_index() % 2, circuit_size / 2);
size_t desired_size = full_poly.end_index() / 2 + full_poly.end_index() % 2;

@jeanmon jeanmon Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a change which was forgotten in a previous PR.

poly = Polynomial(desired_size, circuit_size / 2);
}
}
Expand Down