Skip to content

chore(testnet): default data dir for testnet #12696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maddiaa0 merged 4 commits into from
Mar 13, 2025
Merged

chore(testnet): default data dir for testnet #12696

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f5e6ef
chore: default datadir
Maddiaa0 Mar 12, 2025
7102094
fix
Maddiaa0 Mar 12, 2025
77aae6c
Update yarn-project/aztec/src/cli/chain_l2_config.ts
Maddiaa0 Mar 12, 2025
40203e9
Restrict env vars to type
PhilWindle Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions yarn-project/aztec/src/cli/chain_l2_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import path from 'path';

export type NetworkNames = 'testnet-ignition';

export type L2ChainConfig = {
Expand Down Expand Up @@ -71,4 +73,5 @@ export async function enrichEnvironmentWithChainConfig(networkName: NetworkNames
enrichVar('REGISTRY_CONTRACT_ADDRESS', config.registryAddress);
enrichVar('SEQ_MIN_TX_PER_BLOCK', config.seqMinTxsPerBlock.toString());
enrichVar('SEQ_MAX_TX_PER_BLOCK', config.seqMaxTxsPerBlock.toString());
enrichVar('DATA_DIR', path.join(process.env.HOME || '~', '.aztec', networkName, 'data'));

@PhilWindle PhilWindle Mar 12, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's DATA_DIRECTORY.

@ludamad ludamad Mar 12, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these all have a satisfies EnvVar after them so that relation is checked?

@PhilWindle PhilWindle Mar 13, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, great idea.

Comment thread
Maddiaa0 marked this conversation as resolved.
Outdated
}