Skip to content

chore: Remove roots arg on __compute_fracs in blob lib #12663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Mar 11, 2025
Merged

chore: Remove roots arg on __compute_fracs in blob lib #12663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions noir-projects/noir-protocol-circuits/crates/blob/src/blob.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,14 +289,10 @@ fn compute_factor(z: F) -> F {
factor
}

unconstrained fn __compute_fracs(
z: F,
ys: [F; FIELDS_PER_BLOB],
unconstrained_roots: [F; FIELDS_PER_BLOB],
) -> [F; FIELDS_PER_BLOB] {
unconstrained fn __compute_fracs(z: F, ys: [F; FIELDS_PER_BLOB]) -> [F; FIELDS_PER_BLOB] {
let mut denoms = [F::zero(); FIELDS_PER_BLOB];
for i in 0..FIELDS_PER_BLOB {
denoms[i] = z.__sub(unconstrained_roots[i]); // (z - omega^i)
denoms[i] = z.__sub(ROOTS[i]); // (z - omega^i)
}
let inv_denoms: [F; FIELDS_PER_BLOB] = F::__batch_invert(denoms); // 1 / (z - omega^i), for all i
// We're now done with `denoms` so we can reuse the allocated array to build `fracs`.
Expand All @@ -313,7 +309,7 @@ unconstrained fn __compute_fracs(
fn compute_fracs(z: F, ys: [F; FIELDS_PER_BLOB]) -> [F; FIELDS_PER_BLOB] {
// Safety: We immediately constrain these `fracs` to be correct in the following call
// to `F::evaluate_quadratic_expression`.
let mut fracs: [F; FIELDS_PER_BLOB] = unsafe { __compute_fracs(z, ys, ROOTS) };
let mut fracs: [F; FIELDS_PER_BLOB] = unsafe { __compute_fracs(z, ys) };

if !std::runtime::is_unconstrained() {
for i in 0..FIELDS_PER_BLOB {
Expand Down