Conversation
Contributor
Author
|
Interestingly this change might mean that we can disable the checks that prevent syncing from being done concurrently, since that should never happen anymore. |
Thunkar
approved these changes
Mar 11, 2025
Contributor
Thunkar
left a comment
Thunkar
left a comment
There was a problem hiding this comment.
LGTM and the comments explaining the "why" are excelent
sklppy88
pushed a commit
that referenced
this pull request
Mar 12, 2025
🤖 I have created a new Aztec Packages release --- ## [0.80.0](v0.79.0...v0.80.0) (2025-03-12) ### ⚠ BREAKING CHANGES * disable PXE concurrency ([#12637](#12637)) ### Features * add inspect command to bootstrap ([#12641](#12641)) ([2f0c527](2f0c527)) * disable PXE concurrency ([#12637](#12637)) ([2716898](2716898)) * remove public bytecode from ts ContractArtifact ([#12653](#12653)) ([6345158](6345158)) ### Bug Fixes * **cli:** fix tag resolution for `aztec update --contract` ([#12657](#12657)) ([b58c123](b58c123)) * **docs:** Fix link to source code after code snippets ([#12658](#12658)) ([8bc5daf](8bc5daf)) * fix yarn-project typos in release ([#12652](#12652)) ([93a6f4e](93a6f4e)) * handling undefined block number in sync data provider txe ([#12605](#12605)) ([b764a9a](b764a9a)) * Inject blob sink client config to archiver start ([#12675](#12675)) ([e2e857b](e2e857b)) * Load config from env on archiver start ([#12662](#12662)) ([79579f3](79579f3)) ### Miscellaneous * aztec start should use pxe proving by default ([#12676](#12676)) ([80cd840](80cd840)), closes [#12677](#12677) * downgrade undici so its engine spec is compatible ([#12659](#12659)) ([4f815ea](4f815ea)), closes [#12645](#12645) * fix warning in aztec-nr ([#12647](#12647)) ([3831bab](3831bab)) * Merge is part of verification queue ([#12612](#12612)) ([e324582](e324582)) * Remove roots arg on __compute_fracs in blob lib ([#12663](#12663)) ([8ec910b](8ec910b)) * replace relative paths to noir-protocol-circuits ([f684528](f684528)) * test cli upgrade ([#12506](#12506)) ([fc728f3](fc728f3)) ### Documentation * **feat:** Aztec js intro page ([#11804](#11804)) ([12d8f3f](12d8f3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging #12391 led me to discover that we cannot have concurrent simulations due to contracts now being allowed to read and write to PXE's stores at arbitrary moments. E.g. #12391 was failing CI due to multiple concurrent simulations deleting the same pending partial note from a capsule array.
This PR disables that behavior by putting the problematic tasks in a serial queue. Multiple tests still call PXE expecting concurrency (typically via usage of
await Promise.all), but I thought it made more sense to disable the behavior this way and issue a warning (to unblock #12391) and then worry about removing attempts to achieve concurrent behavior.I considered putting all PXE functions in the serial queue, but refrained from doing so to avoid introducing a larger than strictly needed change. We may want to do this automatically via e.g. monkey-patching to avoid accidentally forgetting a case.