Skip to content

fix: handling undefined block number in sync data provider txe #12605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nventuro merged 1 commit into from
Mar 11, 2025
Merged

fix: handling undefined block number in sync data provider txe #12605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions yarn-project/pxe/src/pxe_oracle_interface/pxe_oracle_interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,10 +718,9 @@ export class PXEOracleInterface implements ExecutionDataProvider {
// Note that while this technically results in historical queries, we perform it at the latest locally synced block
// number which *should* be recent enough to be available, even for non-archive nodes.
const syncedBlockNumber = (await this.syncDataProvider.getBlockNumber())!;
// TODO (#12559): handle undefined syncedBlockNumber
// if (syncedBlockNumber === undefined) {
// throw new Error(`Attempted to deliver a note with an unsynchronized PXE - this should never happen`);
//}
if (syncedBlockNumber === undefined) {
throw new Error(`Attempted to deliver a note with an unsynchronized PXE - this should never happen`);
}

// By computing siloed and unique note hashes ourselves we prevent contracts from interfering with the note storage
// of other contracts, which would constitute a security breach.
Expand Down
2 changes: 2 additions & 0 deletions yarn-project/txe/src/oracle/txe_oracle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,8 @@ export class TXE implements TypedOracle {
// This essentially commits the state updates to the unforked state and sanity checks the roots.
await this.nativeWorldStateService.handleL2BlockAndMessages(l2Block, l1ToL2Messages);

await this.syncDataProvider.setHeader(header);

this.publicDataWrites = [];
this.privateLogs = [];
this.publicLogs = [];
Expand Down