chore(spartan): run setup-otel-resource inside aztec containers#12582
Closed
chore(spartan): run setup-otel-resource inside aztec containers#12582
Conversation
alexghr
reviewed
Mar 13, 2025
| - "/bin/bash" | ||
| - "-c" | ||
| - | | ||
| source /scripts/setup-otel-resource.sh |
Contributor
There was a problem hiding this comment.
FWIW this is sourcing the script file, not the generated config
Contributor
|
The helm template approach looks good to me but I think we need to execute the script and then load the config file (unless I missed where the script was modified to just export env vars directly) |
Member
Author
|
stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
After hotfix #12580 kind-smoke-test time shot up again as there is another init container.
This just runs the script within the service getting the time back down to 4 minutes