Skip to content

chore: Remove scope interpolation from env vars #12522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Mar 6, 2025
Merged

chore: Remove scope interpolation from env vars #12522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions yarn-project/sequencer-client/src/publisher/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const getTxSenderConfigMappings: (
defaultValue: EthAddress.ZERO,
},
publisherPrivateKey: {
env: `${scope}_PUBLISHER_PRIVATE_KEY`,
env: scope === 'PROVER' ? `PROVER_PUBLISHER_PRIVATE_KEY` : `SEQ_PUBLISHER_PRIVATE_KEY`,
description: 'The private key to be used by the publisher.',
parseEnv: (val: string) => (val ? `0x${val.replace('0x', '')}` : NULL_KEY),
defaultValue: NULL_KEY,
Expand All @@ -61,7 +61,7 @@ export const getPublisherConfigMappings: (
scope: 'PROVER' | 'SEQ',
) => ConfigMappingsType<PublisherConfig & L1TxUtilsConfig> = scope => ({
l1PublishRetryIntervalMS: {
env: `${scope}_PUBLISH_RETRY_INTERVAL_MS`,
env: scope === `PROVER` ? `PROVER_PUBLISH_RETRY_INTERVAL_MS` : `SEQ_PUBLISH_RETRY_INTERVAL_MS`,
parseEnv: (val: string) => +val,
defaultValue: 1000,
description: 'The interval to wait between publish retries.',
Expand Down