Skip to content

chore: calculate available memory for noir-projects/bootstrap.sh memsuspend #12419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 7 commits into from
Mar 3, 2025
Merged

chore: calculate available memory for noir-projects/bootstrap.sh memsuspend #12419

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac5aa37
chore: calculate available memory for noir-projects/bootstrap.sh mems…
Maddiaa0 Mar 3, 2025
b78361d
fix: move to memsuspend_limit file
Maddiaa0 Mar 3, 2025
565eeea
Update
Maddiaa0 Mar 3, 2025
4a5647e
fix: remove set -x
Maddiaa0 Mar 3, 2025
3d6f86b
call throughout
ludamad Mar 3, 2025
87052de
Update memsuspend_limit
ludamad Mar 3, 2025
b02555d
Update parallelise
ludamad Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion noir-projects/noir-contracts/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,23 @@ function on_exit() {
trap on_exit EXIT
mkdir -p $tmp_dir

function get_hardware_memory {
local os=$(uname -s)
local total_mem_gb=64 # Default to 64GB

if [[ "$os" == "Darwin" ]]; then
total_mem_bytes=$(sysctl -n hw.memsize)
total_mem_gb=$((total_mem_bytes / 1024 / 1024 / 1024))
elif [[ "$os" == "Linux" ]]; then
total_mem_gb=$(free -g | awk '/^Mem:/ {print $2}')
fi

echo $(( total_mem_gb < 64 ? total_mem_gb : 64 ))

@Maddiaa0 Maddiaa0 Mar 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min(total_mem_gb, 64)

}

hardware_memory=$(get_hardware_memory)
# Set common flags for parallel.
export PARALLEL_FLAGS="-j${PARALLELISM:-16} --halt now,fail=1 --memsuspend ${MEMSUSPEND:-64G}"
export PARALLEL_FLAGS="-j${PARALLELISM:-16} --halt now,fail=1 --memsuspend ${MEMSUSPEND:-${hardware_memory}G}"

# This computes a vk and adds it to the input function json if it's private, else returns same input.
# stdin has the function json.
Expand Down