feat: allow passing AztecNode to SentTx

[olehmisar]

resolves #11469

SentTx uses only public methods, so AztecNode also works when it's passed to SentTx. This is type-only change to not require users type cast AztecNode -> PXE.

There is also DeploySentTx and DeployAccountSentTx but I didn't change their signatures because not sure how useful it is.

[Maddiaa0]

ah nice stuff, if theres anywhere convenient to unit test this it would be great to add one to protect against regressions

[olehmisar]

@Maddiaa0 can't really do that as ./bootstrap.sh fast on github codespaces stopped working after 0.76.4. It gets indefinitely stuck on

noir-contracts  Executing: ./noir-contracts/bootstrap.sh fast (http://ci.aztec-labs.com/f0cac7fed120e1e4)

[Maddiaa0]

@Maddiaa0 can't really do that as ./bootstrap.sh fast on github codespaces stopped working after 0.76.4. It gets indefinitely stuck on

noir-contracts  Executing: ./noir-contracts/bootstrap.sh fast (http://ci.aztec-labs.com/f0cac7fed120e1e4)

Ah i see, I assume the github codespaces machines have less than. 64GB of RAM, to fix run bootstrap with MEMSUSPEND=16GB, it defaults to 64GB

[olehmisar]

@Maddiaa0 yeah, that helped. What do you want to unit test though? It’s only a type definition change

[Thunkar]

Hi @olehmisar, I redid this with some tests and a slight refactor to avoid confusing naming. Feel free to comment here

I don't love how it's implemented, though. All of these interactions are gonna be refactored, but I agree restricting interfaces for the sake of it is not good

[Maddiaa0]

@Maddiaa0 yeah, that helped. What do you want to unit test though? It’s only a type definition change

Always need unit tests