fix(p2p): slashing test + slasher client does not store own state#12380
Merged
fix(p2p): slashing test + slasher client does not store own state#12380
Conversation
edf1aa3 to
b7db740
Compare
spalladino
reviewed
Feb 28, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
63c9281 to
bc0c510
Compare
LHerskind
approved these changes
Mar 3, 2025
Contributor
LHerskind
left a comment
There was a problem hiding this comment.
Mostly comment about comments.
2d6e4e9 to
e64590b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
The problem
Adds methods to the archiver such that the slasher_client does not need to maintain its own tips. I believe that i can make these changes to the p2p client as well