Skip to content

fix(p2p): slashing test + slasher client does not store own state#12380

Merged
Maddiaa0 merged 9 commits intomasterfrom
md/fix-slasher-client
Mar 3, 2025
Merged

fix(p2p): slashing test + slasher client does not store own state#12380
Maddiaa0 merged 9 commits intomasterfrom
md/fix-slasher-client

Conversation

@Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Feb 28, 2025

Overview

The problem

  • the function being used to progress the chain had recently been upgraded to use the redeployed accounts, but this test reorgs them out so they were failing
  • Secondly and most importantly, there was a race condition when detecting the prune.
    • In order to workout the deadline for the vote, it must work out the current slot, to do so, it was getting it from the block header, which was actively being reorged out. This has been replaced with a reference to the epoch cache

Adds methods to the archiver such that the slasher_client does not need to maintain its own tips. I believe that i can make these changes to the p2p client as well

@Maddiaa0 Maddiaa0 requested a review from charlielye as a code owner February 28, 2025 18:20
@Maddiaa0 Maddiaa0 changed the title fix(p2p): slashing + slasher client fix(p2p): slashing test + slasher client does not store own state Feb 28, 2025
@Maddiaa0 Maddiaa0 requested review from LHerskind and removed request for charlielye February 28, 2025 18:23
@Maddiaa0 Maddiaa0 force-pushed the md/fix-slasher-client branch from edf1aa3 to b7db740 Compare February 28, 2025 18:27
@Maddiaa0 Maddiaa0 requested a review from spalladino February 28, 2025 18:28
Copy link
Member Author

Maddiaa0 commented Mar 1, 2025

@Maddiaa0 Maddiaa0 force-pushed the md/fix-slasher-client branch from 63c9281 to bc0c510 Compare March 1, 2025 17:26
@Maddiaa0 Maddiaa0 added the ci-full Run all master checks. label Mar 3, 2025
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comment about comments.

@Maddiaa0 Maddiaa0 force-pushed the md/fix-slasher-client branch from 2d6e4e9 to e64590b Compare March 3, 2025 15:32
@Maddiaa0 Maddiaa0 enabled auto-merge (squash) March 3, 2025 15:33
@Maddiaa0 Maddiaa0 merged commit 8f13fd5 into master Mar 3, 2025
7 checks passed
@Maddiaa0 Maddiaa0 deleted the md/fix-slasher-client branch March 3, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run all master checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants