fix: remove first nullifier emitted in txe#12360
Merged
Conversation
sklppy88
force-pushed
the
ek/fix/12359/remove-first-nullifier-emitted-in-txe
branch
from
25884f1 to
f087c4c
Compare
sklppy88
commented
Feb 28, 2025
| #[test] | ||
| unconstrained fn nullifier_inclusion() { | ||
| let (env) = test::create_note_and_nullify_it(); | ||
| let mut env = TestEnvironment::new(); |
Contributor
Author
There was a problem hiding this comment.
Realized I didn't need this setup
Thunkar
approved these changes
Feb 28, 2025
Contributor
Thunkar
left a comment
Thunkar
left a comment
There was a problem hiding this comment.
Even if the oracle is weird, the alternative was weirder. LGTM!
sklppy88
deleted the
ek/fix/12359/remove-first-nullifier-emitted-in-txe
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @benesjan pointed out in #12215, the approach to use a deterministic nullifier emitted by the TXe was extremely brittle, and should be changed. I looked and found it was actually possible to emit an arbitrary nullifier (albeit through a bit obscure of an oracle), and have adapted the tests to use this oracle.