feat: rename bb write_contract to write_solidity_verifier#12322
Merged
feat: rename bb write_contract to write_solidity_verifier#12322
Conversation
saleel
requested review from
codygunton and
ludamad
and removed request for
charlielye
saleel
force-pushed
the
saleel/bb-logs
branch
from
72b81fb to
48db8d7
Compare
saleel
force-pushed
the
saleel/bb-logs
branch
from
48db8d7 to
a1f3133
Compare
saleel
force-pushed
the
saleel/bb-cli-solidity
branch
from
7f2edb3 to
af20725
Compare
saleel
force-pushed
the
saleel/bb-cli-solidity
branch
from
af20725 to
1856f57
Compare
ludamad
approved these changes
Feb 28, 2025
Collaborator
ludamad
left a comment
ludamad
left a comment
There was a problem hiding this comment.
Good with me once ci passes
saleel
force-pushed
the
saleel/bb-cli-solidity
branch
3 times, most recently
from
a49a087 to
5bebf8a
Compare
saleel
force-pushed
the
saleel/bb-cli-solidity
branch
from
5bebf8a to
4931af2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess
bb write_solidity_verifieris a better subcommand; especially since we use the term "contract" in Aztec context as wellShould have raised this with #11459 but hopefully okay since we have not made a release yet.
--
Will base this PR to master once #12321 is merged (should be automatic)