fix(aztec-nr): Use mutable ref when mutating variable in closure#12311
Merged
TomAFrench merged 1 commit intomasterfrom Feb 27, 2025
Merged
fix(aztec-nr): Use mutable ref when mutating variable in closure#12311TomAFrench merged 1 commit intomasterfrom
TomAFrench merged 1 commit intomasterfrom
Conversation
5 tasks
Contributor
|
This is beyond my Noir knowledge to judge. Whatever works is ok for me. I'll let someone else approve :) |
asterite
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post noir-lang/noir#7488 aztec-nr is going to fail to compile as we now explicitly error when attempting to use a capture mutably (lambda captures are meant to be entirely immutable). The current code only worked because it was done at comptime.