Skip to content

chore: Reenable dapp subscription test #12304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Feb 26, 2025
Merged

chore: Reenable dapp subscription test #12304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions yarn-project/end-to-end/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ function test_cmds {

# fees sub-tests
echo "$prefix simple e2e_fees/account_init"
echo "$prefix simple e2e_fees/dapp_subscription"
echo "$prefix simple e2e_fees/failures"
echo "$prefix simple e2e_fees/fee_juice_payments"
echo "$prefix simple e2e_fees/gas_estimation"
Expand Down
5 changes: 2 additions & 3 deletions yarn-project/end-to-end/src/e2e_fees/dapp_subscription.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ describe('e2e_fees dapp_subscription', () => {
await expectBananasPrivateDelta(-t.SUBSCRIPTION_AMOUNT - transactionFee!, t.SUBSCRIPTION_AMOUNT, 0n);
await expectBananasPublicDelta(0n, 0n, transactionFee!);

// REFUND_AMOUNT is a transparent note note
// REFUND_AMOUNT is a transparent note
});

it('should allow Alice to subscribe by paying with bananas in public', async () => {
Expand Down Expand Up @@ -172,8 +172,7 @@ describe('e2e_fees dapp_subscription', () => {
it('should reject after the sub runs out', async () => {
// Subscribe again. This will overwrite the previous subscription.
await subscribe(new PrivateFeePaymentMethod(bananaFPC.address, aliceWallet), 0);
// TODO(#6651): Change back to /(context.block_number()) as u64 < expiry_block_number as u64/ when fixed
await expect(dappIncrement()).rejects.toThrow(/Note encrypted logs hash mismatch/);
await expect(dappIncrement()).rejects.toThrow(/Block number mismatch/i);
});

it('should reject after the txs run out', async () => {
Expand Down
Loading