Skip to content

feat: Sync from noir#12298

Merged
TomAFrench merged 9 commits intomasterfrom
sync-noir
Feb 26, 2025
Merged

feat: Sync from noir#12298
TomAFrench merged 9 commits intomasterfrom
sync-noir

Conversation

@AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore!: bump msrv to 1.85.0 (noir-lang/noir#7530)
fix: No longer error on INT_MIN globals (noir-lang/noir#7519)
fix: correctly format trait function with multiple where clauses (noir-lang/noir#7531)
chore(ssa): Do not run passes on Brillig functions post Brillig gen (noir-lang/noir#7527)
END_COMMIT_OVERRIDE

AztecBot and others added 4 commits February 26, 2025 16:29
fix: No longer error on INT_MIN globals (noir-lang/noir#7519)
fix: correctly format trait function with multiple where clauses (noir-lang/noir#7531)
chore(ssa): Do not run passes on Brillig functions post Brillig gen (noir-lang/noir#7527)
@guipublic guipublic requested a review from TomAFrench February 26, 2025 18:03
@TomAFrench TomAFrench merged commit e200f8b into master Feb 26, 2025
9 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch February 26, 2025 18:30
TomAFrench added a commit that referenced this pull request Feb 26, 2025
* master: (31 commits)
  feat: Slack message to ci channel tagging owners on flakes. (#12284)
  fix: slack notify was broken by quoted commit titles
  revert: "chore: Fix and reenable fees-settings test (#12302)"
  fix: run arm64 on master (#12307)
  yolo fix
  chore: Fix and reenable fees-settings test (#12302)
  feat!: rename compute_nullifier_without_context (#12308)
  chore: Lazy loading artifacts everywhere (#12285)
  chore: Reenable dapp subscription test (#12304)
  chore: Run prover test with fake proofs when requested (#12305)
  chore: Do not set CI_FULL outside CI (#12300)
  chore: new mnemonic deployments on sepolia (#12076)
  chore!: enable multiple L1 nodes to be used (#11945)
  chore: remove no longer supported extension from vscode/extension.json (#12303)
  fix(e2e): p2p_reqresp (#12297)
  feat: Sync from noir (#12298)
  chore: enabling `e2e_contract_updates` in CI + nuking irrelevant test (#12293)
  feat: prepend based merge (#12093)
  feat: fetch addresses from registry (#12000)
  feat: live logs (#12271)
  ...
guipublic pushed a commit that referenced this pull request Feb 28, 2025
The rust MSRV got bumped in
#12298 but we didn't
catch that we're still using a stale devbox image due to the check in
`bootstrap.sh` not being updated properly. CI's passing due to cargo
automatically installing the proper toolchain at runtime.

I've completed the relevant changes to fix the build image /
`./bootstrap.sh check` in this PR but I'm not up to date on how pushing
an update to devbox should be done (or if CI still automatically pushes
to dockerhub anymore).

@charlielye @ludamad Could one of you help me with fixing this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants