Skip to content

fix: don't try to get bench artifacts on external PR #12157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 2 commits into from
Feb 20, 2025
Merged

fix: don't try to get bench artifacts on external PR #12157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3200e89
fix bench run
ludamad Feb 20, 2025
6409fa0
Update ci3.yml
ludamad Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,13 @@ jobs:
./ci.sh ec2

- name: Download benchmarks
if: matrix.settings.arch == 'amd64' && github.ref_name == 'master'
if: matrix.settings.arch == 'amd64' && github.event_name == 'push' && github.ref_name == 'master'
run: |
./ci3/cache_download barretenberg-bench-results-$(git rev-parse HEAD).tar.gz
./ci3/cache_download yarn-project-bench-results-$(git rev-parse HEAD).tar.gz

- name: Store barretenberg benchmark result
if: matrix.settings.arch == 'amd64' && github.ref_name == 'master'
if: matrix.settings.arch == 'amd64' && github.event_name == 'push' && github.ref_name == 'master'
continue-on-error: true
uses: benchmark-action/github-action-benchmark@4de1bed97a47495fc4c5404952da0499e31f5c29
with:
Expand All @@ -133,7 +133,7 @@ jobs:
max-items-in-chart: 50

- name: Store yarn project benchmark result
if: matrix.settings.arch == 'amd64' && github.ref_name == 'master'
if: matrix.settings.arch == 'amd64' && github.event_name == 'push' && github.ref_name == 'master'
continue-on-error: true
uses: benchmark-action/github-action-benchmark@4de1bed97a47495fc4c5404952da0499e31f5c29
with:
Expand Down