feat(barretenberg): Graph methods for circuit analysis (part 2) by DanielKotov · Pull Request #12130 · AztecProtocol/aztec-packages

DanielKotov · 2025-02-20T08:15:44Z

This PR continues Graph Description for Ultra Circuit Builder.

There were added functions for processing:

auxiliary block (bigfield limb accumulation, bigfield product, RAM/ROM tables read gates)
poseidon2s external and internal blocks.

There were tested primitives like Poseidon2s hash function, Dynamic Array and Bigfield. Poseidon and Dynamic Array have been fully tested. Bigfield has been tested halfway.

There has been completed function for arithmetic block. (q_arith == 3 case), and it processes fix_witness another way.

There was added new filtering mechanism for finalize_circuit() function using tau and range tags, filtering mechanism for RAM/ROM gate and filtering mechanism for variables that were fixed.

Also there was added new data structure for containing information about gates for every variable. It can be helpful in further filtering mechanisms or debugging process.

No vulnerabilities were found by static analyzer.

…rray

…ests

Rumata888 · 2025-02-27T17:14:31Z

barretenberg/cpp/src/barretenberg/boomerang_value_detection/graph_description_sha256.test.cpp

+ all these tests check graph description for sha256 circuits. All circuits have to consist of 1 connected component
 */

 TEST(boomerang_stdlib_sha256, test_graph_for_sha256_55_bytes)


It's better to add separate descriptions to each test. If I go to the last one, I don't know that there is a description here.

Rumata888 · 2025-02-27T17:25:47Z

barretenberg/cpp/src/barretenberg/boomerang_value_detection/graph_description_sha256.test.cpp

+    EXPECT_EQ(variables_in_one_gate.size(), 0);
+    if (variables_in_one_gate.size() > 0) {
+        for (const auto& elem : variables_in_one_gate) {
+            info("elem == ", elem);


It's better to remove info from tests in the general case, but here it's not an issue since the branch is not being taken

Rumata888 · 2025-02-27T18:19:55Z

barretenberg/cpp/src/barretenberg/boomerang_value_detection/graph_description.test.cpp

-    auto variables_in_one_gate = graph.show_variables_in_one_gate(circuit_constructor);
-    bool result = num_connected_components == 256;
-    EXPECT_EQ(result, true);
+    [[maybe_unused]] auto variables_in_one_gate = graph.show_variables_in_one_gate(circuit_constructor);


Why is this unused?

Rumata888 · 2025-02-27T18:24:40Z

barretenberg/cpp/src/barretenberg/boomerang_value_detection/graph_description_bigfield.test.cpp

+    auto connected_components = graph.find_connected_components();
+    EXPECT_EQ(connected_components.size(), 1);
+    auto variables_in_one_gate = graph.show_variables_in_one_gate(builder);
+    EXPECT_EQ(variables_in_one_gate.size(), 2);


Why are there 2?

Rumata888 · 2025-02-27T18:25:17Z

barretenberg/cpp/src/barretenberg/boomerang_value_detection/graph_description_bigfield.test.cpp

+    fq_ct b(witness_ct(&builder, fr(uint256_t(inputs[1]).slice(0, fq_ct::NUM_LIMB_BITS * 2))),
+            witness_ct(&builder, fr(uint256_t(inputs[1]).slice(fq_ct::NUM_LIMB_BITS * 2, fq_ct::NUM_LIMB_BITS * 4))));
+    fq_ct c = a * b;
+    for (size_t i = 0; i < num_repetitions; ++i) {


There is no need to repeat these operations

Rumata888 · 2025-02-27T18:25:32Z

barretenberg/cpp/src/barretenberg/boomerang_value_detection/graph_description_bigfield.test.cpp

+{
+    auto builder = Builder();
+    size_t num_repetitions = 4;
+    for (size_t i = 0; i < num_repetitions; ++i) {


There is no need to repeat these operations

Rumata888 · 2025-02-27T18:25:58Z

barretenberg/cpp/src/barretenberg/boomerang_value_detection/graph_description_bigfield.test.cpp

+{
+    auto builder = Builder();
+    size_t num_repetitions = 10;
+    for (size_t i = 0; i < num_repetitions; ++i) {


Here and basically everywhere further there is no need to repeat operations

🤖 I have created a new Aztec Packages release --- ## [0.78.0](v0.77.1...v0.78.0) (2025-03-07) ### ⚠ BREAKING CHANGES * convert `TraitMethodNotInScope` to error (noir-lang/noir#7427) * bump bb version to v0.77.0 (noir-lang/noir#7599) * remove merkle module from stdlib (noir-lang/noir#7582) * remove deprecated hash functions from stdlib (noir-lang/noir#7477) * **frontend:** Restrict capturing mutable variable in lambdas (noir-lang/noir#7488) * remove U128 struct from stdlib (noir-lang/noir#7529) ### Features * **barretenberg:** Graph methods for circuit analysis (part 2) ([#12130](#12130)) ([ec4c0c4](ec4c0c4)) * **cli:** Log and replay oracle transcript (noir-lang/noir#7417) ([f13b729](f13b729)) * Compare bincode to CBOR, FlexBuffers and Protobuf - implement best (noir-lang/noir#7513) ([8eb727c](8eb727c)) * **experimental:** Enable ownership syntax (noir-lang/noir#7603) ([1a3c112](1a3c112)) * **experimental:** Issue errors for unreachable match branches (noir-lang/noir#7556) ([f13b729](f13b729)) * nullify just-added notes ([#12552](#12552)) ([dcba7a4](dcba7a4)) * perform constant sha256 compressions at compile-time (noir-lang/noir#7566) ([f13b729](f13b729)) * relate errors to macro built-ins errors (noir-lang/noir#7609) ([fbaa634](fbaa634)) * simplify simple conditionals for brillig (noir-lang/noir#7205) ([f13b729](f13b729)) * Support `<Type as Trait>::method` in expressions (noir-lang/noir#7551) ([f13b729](f13b729)) * Sync from aztec-packages (noir-lang/noir#7606) ([8eb727c](8eb727c)) * teardown in call interface ([#12499](#12499)) ([062df02](062df02)) * translation evaluations with zk ([#12222](#12222)) ([568982d](568982d)) ### Bug Fixes * **avm:** use the correct number of rows in check_interaction ([#12519](#12519)) ([b1284ef](b1284ef)) * aztec-up ([#12509](#12509)) ([3ddb6de](3ddb6de)) * bbup ([#12555](#12555)) ([e7b5353](e7b5353)) * Bitwise lookup ([#12471](#12471)) ([a38f353](a38f353)) * **ci:** remove regex - transfer explicitly ([#12525](#12525)) ([352bb1d](352bb1d)) * Cl/fix arm anvil ([#12565](#12565)) ([e4bfbd1](e4bfbd1)) * compare Quoted by expanding interned values (noir-lang/noir#7602) ([1a3c112](1a3c112)) * Display causes but not stack trace in CLI error report (noir-lang/noir#7584) ([f13b729](f13b729)) * **experimental:** Fix execution of match expressions with multiple branches (noir-lang/noir#7570) ([1a3c112](1a3c112)) * fix a few cases where safety comment wasn't correctly identified (noir-lang/noir#7548) ([f13b729](f13b729)) * fix bbup and add CI ([#12541](#12541)) ([1b2604c](1b2604c)) * Fix the config ([#12513](#12513)) ([fb9fac6](fb9fac6)) * **frontend:** Restrict capturing mutable variable in lambdas (noir-lang/noir#7488) ([f13b729](f13b729)) * FunctionDefinition::as_typed_expr didn't work well for trait imp… (noir-lang/noir#7611) ([1a3c112](1a3c112)) * Log to `stderr` (noir-lang/noir#7585) ([f13b729](f13b729)) * **LSP:** references/rename only when underlying span has the correct… (noir-lang/noir#7598) ([8eb727c](8eb727c)) * make vk metadata actual witnesses ([#12459](#12459)) ([dada06f](dada06f)) * no fast deployments when the boot node needs to restart. ([#12557](#12557)) ([866582e](866582e)) * **node:** drop log level of handler not registered ([#12523](#12523)) ([cb7e42d](cb7e42d)) * override bb path in cli-wallet PXE config ([#12511](#12511)) ([0c3024e](0c3024e)) * publish-bb-mac.yml version replace ([#12554](#12554)) ([7e89dfb](7e89dfb)) * release bb-mac ([fac5fb5](fac5fb5)) * Revert "make vk metadata actual witnesses" ([#12534](#12534)) ([ed46a3c](ed46a3c)) * shift right overflow in ACIR with unknown var now returns zero (noir-lang/noir#7509) ([f13b729](f13b729)) * TokensPrettyPrinter was missing some spaces between tokens (noir-lang/noir#7607) ([1a3c112](1a3c112)) * yarn-project e2e bench ([#12547](#12547)) ([b40b904](b40b904)) ### Miscellaneous * add some extra tests (noir-lang/noir#7544) ([f13b729](f13b729)) * add underscore parameter documentation (noir-lang/noir#7562) ([1a3c112](1a3c112)) * add yaml aliases in .test_patterns.yml ([#12516](#12516)) ([3ee8d51](3ee8d51)) * address some frontend tests TODOs (noir-lang/noir#7554) ([f13b729](f13b729)) * addressing remaining feedback in PR 12182 ([#12494](#12494)) ([f733879](f733879)), closes [#12193](#12193) * bump `light-poseidon` (noir-lang/noir#7568) ([f13b729](f13b729)) * bump bb version to v0.77.0 (noir-lang/noir#7599) ([f13b729](f13b729)) * bump external pinned commits (noir-lang/noir#7561) ([f13b729](f13b729)) * bump external pinned commits (noir-lang/noir#7565) ([f13b729](f13b729)) * bump external pinned commits (noir-lang/noir#7581) ([f13b729](f13b729)) * bump external pinned commits (noir-lang/noir#7601) ([f13b729](f13b729)) * bump external pinned commits (noir-lang/noir#7618) ([fbaa634](fbaa634)) * bump ring to address advisory (noir-lang/noir#7619) ([fbaa634](fbaa634)) * Cleaner PXE ([#12515](#12515)) ([a69f416](a69f416)) * cleanup committing and masking utility ([#12514](#12514)) ([9f57048](9f57048)) * **cli:** exclude kind smoke test from flake list ([#12518](#12518)) ([778bfa6](778bfa6)) * **cli:** Forward `nargo execute` to `noir_artifact_cli` (noir-lang/noir#7406) ([f13b729](f13b729)) * convert `TraitMethodNotInScope` to error (noir-lang/noir#7427) ([fbaa634](fbaa634)) * explode aliases when looking up owners in `.test_patterns.yml` ([#12526](#12526)) ([2e0d791](2e0d791)) * fix trait import issues ([#12500](#12500)) ([fd9f145](fd9f145)) * Fix yarn install immutable issues ([#12539](#12539)) ([fb9ada3](fb9ada3)), closes [#12538](#12538) * More config defaults and forward p2p ports ([#12529](#12529)) ([2c45fb9](2c45fb9)) * **node:** return correct node version ([#12520](#12520)) ([5502901](5502901)) * **profiler:** Add option to only get the total sample count for the `execution-opcodes` command (noir-lang/noir#7578) ([f13b729](f13b729)) * put RcTracker as part of the DIE context (noir-lang/noir#7309) ([f13b729](f13b729)) * remove deprecated hash functions from stdlib (noir-lang/noir#7477) ([f13b729](f13b729)) * remove FileDiagnostic (noir-lang/noir#7546) ([f13b729](f13b729)) * remove merkle module from stdlib (noir-lang/noir#7582) ([f13b729](f13b729)) * Remove scope interpolation from env vars ([#12522](#12522)) ([70942e9](70942e9)) * remove U128 struct from stdlib (noir-lang/noir#7529) ([f13b729](f13b729)) * replace relative paths to noir-protocol-circuits ([f20c0dd](f20c0dd)) * replace relative paths to noir-protocol-circuits ([4365064](4365064)) * restore bb --version ([#12542](#12542)) ([ab13d43](ab13d43)) * restore method syntax on `get_storage_slot` calls ([#12532](#12532)) ([8e9f594](8e9f594)) * rm unused methods ([#12544](#12544)) ([ed1dbdc](ed1dbdc)) * some SSA improvements (noir-lang/noir#7588) ([f13b729](f13b729)) * **spartan:** kind test speedup ([#12478](#12478)) ([8ede7b1](8ede7b1)) * **ssa:** Turn the Brillig constraints check back on by default (noir-lang/noir#7404) ([f13b729](f13b729)) * track more critical libraries (noir-lang/noir#7604) ([f13b729](f13b729)) * update and lock AVM's lockfile ([#12533](#12533)) ([2babc50](2babc50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

DanielKotov requested a review from Rumata888 February 20, 2025 10:54

Rumata888 mentioned this pull request Feb 21, 2025

feat(barretenberg): Graph methods for circuit analysis (part 2) #12110

Closed

DanielKotov added 24 commits February 26, 2025 13:31

graph description for stdlib/poseidon2 hash function + tests

802fa79

first steps for auxiliary gates

3347d0c

add graph description for bigfield product cases

ee7b268

add auxiliary block graph creation + resize method test for dynamic a…

84fdfd5

…rray

rarewrite graph description fro or ram and rom tables + tests

e3df3b1

tests for dynamic array + ram_rom

8fca4ae

fix error of graph creation for q_arith == 3

b4fbfa8

new graph constructor

8f0d9ee

tests modification

c72eba5

redesign of the constructor for graph creation

0976c51

new tests for poseidon2s + other tests redesign

be07cb6

new tests for bigfield primitive

1df6f4a

add commentaries for new functions

d865da8

commentaries for poseidon2s tests

1cc712f

tests descriptiion for ram/rom tables

815bcb7

commentaries for bigfield and dynamic array tests

55b01e7

this test fifile is useless now, sso we can remove it

38bf998

final graph description + removing some unnesecary information from t…

fe226d7

…ests

final tests for ran and rom tables

e67ff24

final tests fixes after full run

0c155d7

some problems with commits

d9e375e

merge conflicts again

9103779

some probles with merge again

0f785eb

changes after format.sh run

86f9a35

DanielKotov force-pushed the dk/boomerang_value_detection_final2 branch from 6a67e67 to 86f9a35 Compare February 26, 2025 13:34

Rumata888 reviewed Feb 27, 2025

View reviewed changes

Rumata888 and others added 3 commits February 27, 2025 18:27

Automatic doc rewriting

fd4dd1c

сorrection of Kesha's remarks in tests files

648d19e

More fixes

73c6062

Rumata888 approved these changes Mar 5, 2025

View reviewed changes

DanielKotov merged commit ec4c0c4 into master Mar 6, 2025
6 checks passed

DanielKotov deleted the dk/boomerang_value_detection_final2 branch March 6, 2025 12:15

AztecBot mentioned this pull request Mar 6, 2025

chore(master): release 0.78.0 #12508

Merged

Rumata888 mentioned this pull request Mar 18, 2025

Static analyzer for standard an ultra circuits AztecProtocol/barretenberg#1086

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(barretenberg): Graph methods for circuit analysis (part 2)#12130

feat(barretenberg): Graph methods for circuit analysis (part 2)#12130
DanielKotov merged 27 commits intomasterfrom
dk/boomerang_value_detection_final2

DanielKotov commented Feb 20, 2025

Uh oh!

Rumata888 Feb 27, 2025

Uh oh!

Rumata888 Feb 27, 2025

Uh oh!

Rumata888 Feb 27, 2025

Uh oh!

Rumata888 Feb 27, 2025

Uh oh!

Rumata888 Feb 27, 2025

Uh oh!

Rumata888 Feb 27, 2025

Uh oh!

Rumata888 Feb 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

DanielKotov commented Feb 20, 2025

Uh oh!

Rumata888 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Rumata888 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Rumata888 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Rumata888 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Rumata888 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Rumata888 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Rumata888 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants