Skip to content

chore: Do not allow changes to package json during CI yarn install #12125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 1 commit into from
Feb 19, 2025
Merged

chore: Do not allow changes to package json during CI yarn install #12125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions yarn-project/.yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ logFilters:
level: discard

nodeLinker: node-modules

# Do not allow 'yarn install' on CI to format package.json files,
# otherwise it will change their hash and bust the cache
immutablePatterns: ['**/package.json']
6 changes: 4 additions & 2 deletions yarn-project/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,10 @@ function build {
echo_header "yarn-project build"
denoise "./bootstrap.sh clean-lite"
if [ "${CI:-0}" = 1 ]; then
# If in CI mode, retry as bcrypto can sometimes fail mysteriously and we don't expect actual yarn install errors.
denoise "retry yarn install"
# If in CI mode, retry as bcrypto can sometimes fail mysteriously.
# We set immutable since we don't expect the yarn.lock to change. Note that we have also added all package.json
# files to yarn immutablePatterns, so if they are also changed, this step will fail.
denoise "retry yarn install --immutable"
Copy link
Collaborator

@ludamad ludamad Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant as yarn install reacts to CI being set

Copy link
Collaborator

@ludamad ludamad Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't hate it tho)

Copy link
Contributor Author

@spalladino spalladino Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree it's redundant, but I'd rather be explicit

else
denoise "yarn install"
fi
Expand Down