chore: work around bugs using cache_content_hash#12124
Merged
Conversation
spalladino
approved these changes
Feb 19, 2025
spalladino
approved these changes
Feb 19, 2025
ludamad
pushed a commit
that referenced
this pull request
Feb 19, 2025
…12125) Running `yarn install` will format the package.json for all packages in the workspace. This will cause `cache_content_hash` to fail on CI due to changed files, which (before #12124) caused the build to terminate abruptly (see [here](https://github.com/AztecProtocol/aztec-packages/actions/runs/13422411604/job/37497960586?pr=12096#step:7:109) for an example). This PR adds all package.json files to yarn's `immutablePatterns`, so if it detects that the install process changed them it, it will fail with `The checksum for **/package.json has been modified by this install, which is explicitly forbidden.` and a nice exit code, which should be visible on the CI run. This only applies to CI runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.