chore(p2p): log if rate limit was peer or global#12116
Merged
Conversation
natebeauregard
approved these changes
Feb 19, 2025
Contributor
natebeauregard
left a comment
natebeauregard
left a comment
There was a problem hiding this comment.
Left one question about the peer scoring refactor but otherwise LGTM!
| return false; | ||
| default: | ||
| return true; | ||
| if (rateLimitStatus === RateLimitStatus.DeniedGlobal) { |
Contributor
There was a problem hiding this comment.
Should this conditional check that the RateLimitStatus is DeniedPeer instead of DeniedGlobal before penalizing?
Suggested change
| if (rateLimitStatus === RateLimitStatus.DeniedGlobal) { | |
| if (rateLimitStatus === RateLimitStatus.DeniedPeer) { |
Member
Author
There was a problem hiding this comment.
oh god youre right, will add unit test too
edit: good news, existing unit test caught it, this was just a typo
Maddiaa0
deleted the
md/02-19-chore_log_if_rate_limit_status_was_peer___global_rate_limit
branch
TomAFrench
added a commit
that referenced
this pull request
Feb 19, 2025
* master: (264 commits) chore(p2p): log if rate limit was peer or global (#12116) chore: @aztec/stdlib pt1 -> cleanup circuits js (#12039) chore(tests): shorten block times in e2e p2p tests (#12073) fix: darwin properly erroring (#12113) chore: add missing import (#12111) fix: yarn remake-constants (#12109) chore: fix error in oracle definition (#12090) fix: Don't consider skipping (#10598) fix: Use gas billed in block header building (#12101) fix(avm): disable wrong sha skippable (#12099) chore: Provide defaults for bb and acvm in release image (#12105) fix(avm): break TS dependency cycle (#12103) feat: IVC gates command in WASM (#11792) fix: SharedMutable compilation warnings (#12098) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat: Sync from noir (#12064) chore: Fix unbound CI variable on release image bootstrap (#12095) ...
TomAFrench
added a commit
that referenced
this pull request
Feb 19, 2025
* master: (264 commits) chore(p2p): log if rate limit was peer or global (#12116) chore: @aztec/stdlib pt1 -> cleanup circuits js (#12039) chore(tests): shorten block times in e2e p2p tests (#12073) fix: darwin properly erroring (#12113) chore: add missing import (#12111) fix: yarn remake-constants (#12109) chore: fix error in oracle definition (#12090) fix: Don't consider skipping (#10598) fix: Use gas billed in block header building (#12101) fix(avm): disable wrong sha skippable (#12099) chore: Provide defaults for bb and acvm in release image (#12105) fix(avm): break TS dependency cycle (#12103) feat: IVC gates command in WASM (#11792) fix: SharedMutable compilation warnings (#12098) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat: Sync from noir (#12064) chore: Fix unbound CI variable on release image bootstrap (#12095) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When running testbench, some rate limit logs were unclear if they were due to peer specific limits ( misbehaviour ) or due
to global limits ( ddos prevention ) this change fixes the error message to include what offense has been observed