Skip to content

fix: inject dockerhub creds #12072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 5 commits into from
Feb 18, 2025
Merged

fix: inject dockerhub creds #12072

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df85d04
fix dockerhub login
ludamad Feb 18, 2025
43f2452
inject dockerhub creds
ludamad Feb 18, 2025
f8039c3
Update ci3.yml
ludamad Feb 18, 2025
bd0c2c3
Update bootstrap_ec2
ludamad Feb 18, 2025
edd0f6c
fix
ludamad Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ jobs:
LOG_ID: ${{ github.run_id }}
NETLIFY_SITE_ID: ${{ secrets.NETLIFY_SITE_ID }}
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }}
run: |
./ci.sh ec2
- name: Download benchmarks
Expand Down Expand Up @@ -153,6 +154,7 @@ jobs:
ARCH: arm64
LOG_ID: ${{ github.run_id }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }}
run: |
./ci.sh ec2

Expand Down
4 changes: 4 additions & 0 deletions ci3/bootstrap_ec2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ container_script=$(cat <<EOF
git checkout -b $REF_NAME
export CI_FULL=$CI_FULL
source ci3/source

if [ -n "${DOCKERHUB_PASSWORD:-}" ] && [ "$REF_NAME" == "master" ] ; then
echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u aztecprotocolci --password-stdin

@ludamad ludamad Feb 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we restrict to master or release tags to give less surface area from external PRs

fi
echo "env: REF_NAME=$REF_NAME COMMIT_HASH=$COMMIT_HASH CURRENT_VERSION=$CURRENT_VERSION CI_FULL=$CI_FULL"
if semver check "$REF_NAME"; then
echo "Performing a release because $REF_NAME is a semver."
Expand Down