-
Notifications
You must be signed in to change notification settings - Fork 615
chore!: enable multiple L1 nodes to be used #11945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
1140b31
fix: support multiple L1 node URLs
spypsy b2faca5
leftovers
spypsy 16146ca
more fixes
spypsy 4f79daf
Merge branch 'master' into spy/multi-rpc-urls
spypsy 286954a
fix --rpc-url usage
spypsy f0e23a1
Merge branch 'master' into spy/multi-rpc-urls
spypsy 0fad63b
fix imports + tests
spypsy 09ea2b1
undo test change
spypsy d6334bb
update --l1-rpc-urls
spypsy dd1e0ef
fix imports
spypsy 6d45015
another import
spypsy 4fb917e
externalHosts
spypsy d129c99
Merge branch 'master' into spy/multi-rpc-urls
spypsy 4836dd9
post-merge fixes
spypsy bbacaaf
more post-merge fixes
spypsy 4a91b45
fix e2e test
spypsy 8714406
Merge branch 'master' into spy/multi-rpc-urls
spypsy 29a1311
Merge branch 'master' into spy/multi-rpc-urls
spypsy 24ccc68
Merge branch 'master' into spy/multi-rpc-urls
spypsy da0e3cb
PR Fixes
spypsy 842ae5d
update docs
spypsy 685d0c5
update docs
spypsy 12cc436
Merge branch 'master' into spy/multi-rpc-urls
spypsy 688014a
fix typings
spypsy aa5fa6c
Merge branch 'master' into spy/multi-rpc-urls
spypsy 8e79c39
fix wallet client types
spypsy e438592
Merge branch 'master' into spy/multi-rpc-urls
spypsy eca0f24
use multi-urls in cheatcode
spypsy 889caad
Merge branch 'master' into spy/multi-rpc-urls
spypsy fe3d7d3
fix helper spartan script
spypsy c489937
fix e2e cheat_codes
spypsy 85c007f
Merge branch 'master' into spy/multi-rpc-urls
spypsy 1547a62
rm unused import
spypsy 67c81a9
PR Fixes
spypsy d58918e
Merge branch 'master' into spy/multi-rpc-urls
spypsy fc382de
deploy l1 contracts fixes
spypsy bb6975c
fix type imports
spypsy 9405407
update gh secret names
spypsy 36c9e22
break, don't return
spypsy b111170
no need to retry get-chain-id
spypsy da839b8
Merge branch 'master' into spy/multi-rpc-urls
spypsy 4be11a4
Merge branch 'master' into spy/multi-rpc-urls
spypsy 3bd421e
merge fix
spypsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to pluralize the secret as well? (I'm fine if we don't, just checking we didn't chan ge the secret but forgot to change here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only for consistency's sake, will do